Remove hardcoded cointype ID in isEthermintLike function #848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Remove hardcoded cointype ID in
isEthermintLike
functionDescription:
Problem Statement:
The hardcoded cointype ID of
60
in theisEthermintLike
function limits its flexibility and causes issues for networks that do not use this cointype, such as the Kava testnet.Proposed Changes:
chainInfo.bip44.coinType === 60 ||
from theisEthermintLike
function.Background:
As per Kava Labs' new update, Kava Mainnet adopted a new cointype ID, moving away from the standard cointype of
60
. This change makes it necessary to remove the hardcoded value to make Keplr Wallet compatible with other networks, including Kava testnet.Background information
Resolves #800 Github Issue
Files Changed:
packages/background/src/keyring/service.ts
Impact:
This change will make Keplr Wallet more flexible and allow compatibility with networks that do not use the hardcoded cointype ID.
https://github.com/chainapsis/keplr-chain-registry/blob/main/cosmos/kava_2222.json