Add new phases in getUpgradePhases and NetworkId constants #97
Conversation
|
| @@ -358,7 +358,8 @@ export interface ClaimAmountParams { | |||
| } | |||
|
|
|||
| export interface UpgradePhasesReply { | |||
| SunrisePhase: number | |||
There was a problem hiding this comment.
I was following this:
https://github.com/chain4travel/caminogo/blob/dev/vms/platformvm/camino_service.go#L1051
Is SunrisePhase still relevant?
There was a problem hiding this comment.
It's back, but made optional, with all the other phases
src/utils/constants.ts
Outdated
| export const ColumbusID = "1001" | ||
| export const CaminoID = "1000" | ||
|
|
||
| export const BERLINPHASETIME: Map<string, Date> = new Map([ |
There was a problem hiding this comment.
please add athens and sunrise as well, so we'll have it in js sdk
There was a problem hiding this comment.
also, I would suggest to add some default timestamp for unknown network ids
.run/Get Upgrade Phases.run.xml
Outdated
| @@ -0,0 +1,5 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
| <configuration default="false" name="Get Upgrade Phases" type="NodeJSConfigurationType" application-parameters="examples/platformvm/getUpgradePhases.ts" path-to-node="$USER_HOME$/.nvm/versions/node/v16.20.2/bin/node" node-parameters="-r tsconfig-paths/register" path-to-js-file="node_modules/ts-node/dist/bin.js" working-dir="$PROJECT_DIR$"> | |||
There was a problem hiding this comment.
what's this file used for ? are we still using node 16 in caminojs ?
There was a problem hiding this comment.
This is a Webstorm version of run file such as "launch.json" is in VS code.
It helps to run the examples within the WebStorm IDE and thus enables debugging within the IDE.
Node is down to v16.20.0 cause otherwise the examples don't run - I can adjust the examples to be compatible with higher versions. It's only a matter of awaiting of the main function within the examples
There was a problem hiding this comment.
if its ide specific, it should be gitignored
There was a problem hiding this comment.
Gitignored. In the next release, I will increase the node version required to run the examples and add to README.md how to set up run files (to enable examples debugging) via IDE-specific run files.
src/utils/constants.ts
Outdated
| export const BERLINPHASETIME: Map<string, Date> = new Map([ | ||
| [KopernikusID, new Date("2024-04-13T00:00:00Z")], | ||
| [ColumbusID, new Date("2024-08-07T00:00:00Z")], | ||
| [CaminoID, new Date("2024-08-17T00:00:00Z")] |
There was a problem hiding this comment.
for Berlin, I think this date is too early.
There was a problem hiding this comment.
@mo-c4t Do you know where it is possible to check the dates? The only source I have is https://github.com/chain4travel/caminogo/blob/dev/version/constants.go#L184
There was a problem hiding this comment.
We still don't have final dates. but I think you can put the dates more into the future from Columbus and Camino until we have final dates. what do you think @evlekht ?
There was a problem hiding this comment.
yes, ofc, put something temporal
|
@SamJaarsma we need the dates for Berlin and Cairo if possible |
|
After discussion on currently daily we decided to use pvm getUpgradePhases api for now, because we'll be able to hardcode only camino and columbus network phase timestamps. For the rest we need node api that will return actual timestamps, but we don't have such api yet. |
VjeraTurk
changed the title
Why this should be merged
For feature flag to work with Berlin Phase (and defined future or past phases in the same way )
How this works
getUpgradePhasespropagates a call to the node and answers whether the phase is activated.Answers NaN if the phase is not defined in caminogo node.
How this was tested
By running the Example for
getUpgradePhases(added Webstorm Run file)NOTE POST MERGE:
Must be published the old way - using dist branch the way @mo-c4t did for rc-1