Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DAC-Related Transaction Types and API Requests #87

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

aeddaqqa
Copy link

@aeddaqqa aeddaqqa commented May 21, 2024

Extend CaminoJS with New DAC-Related Transaction Types and API Requests

This pull request introduces enhancements to the CaminoJS library by adding new transaction types and API requests related to DAC. The new transaction types included are AddProposalTx and AddVoteTx, aimed at streamlining proposal submission and voting processes within DACs.

Features:

  1. AddProposalTx

    • Introduced a new transaction type, AddProposalTx, which allows the addition of proposals.
  2. AddVoteTx

    • Added a new transaction type, AddVoteTx, to facilitate voting on proposals.
  3. Proposal Types

    • Added support for two new proposal types:
      • NewMember: For proposing the addition of new members.
      • ExcludeMember: For proposing the exclusion of existing members.
  4. ExcludeMemberProposal

    • Implemented support for the new ExcludeMemberProposal type.
  5. AdminProposal

    • Introduced a new proposal type, AdminProposal
  6. Address State

    • Added a new address state specific to Camino-only proposers.

Fixes:

  1. Multisig Transaction Issues
    • Resolved issues related to creating multisig transactions for both AddProposal and AddVote transaction types.

Changes:

  • feat(addproposal): Added AddProposalTx.
  • feat(addvote): Added AddVoteTx.
  • feat(proposal): Added NewMember and ExcludeMember proposal types.
  • feat(exludememberproposal): Added support for ExcludeMemberProposal.
  • feat(adminproposal): Added AdminProposal type.
  • feat(adminProposal): Added new proposal type adminProposal.
  • feat(addressState): Added new address state for Camino-only proposer.
  • fix(addProposal, addVote): Resolved issues creating multisig transactions.

@aeddaqqa aeddaqqa requested a review from knikos May 21, 2024 15:43
@aeddaqqa aeddaqqa force-pushed the add-new-field-proposal-tx branch from 6151a21 to e3c593a Compare May 21, 2024 15:46
Copy link

github-actions bot commented May 21, 2024

⚠️ Found errors/fatal log records. Please review them(job:e2e, step:"Check produced logs") and resolve this comment.

1 errors
0 fatal

@aeddaqqa aeddaqqa force-pushed the add-new-field-proposal-tx branch 3 times, most recently from f063aa0 to 1fadff4 Compare May 27, 2024 09:22
@aeddaqqa aeddaqqa force-pushed the add-new-field-proposal-tx branch from 1fadff4 to ed71de7 Compare May 27, 2024 10:39
knikos
knikos previously requested changes May 28, 2024
Copy link
Member

@knikos knikos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@aeddaqqa aeddaqqa requested a review from VjeraTurk June 2, 2024 17:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment present

@VjeraTurk VjeraTurk dismissed knikos’s stale review June 3, 2024 08:48

The hange was done

…cludeMemberProposal/BaseFee and remove unused comments
@aeddaqqa aeddaqqa requested a review from VjeraTurk June 4, 2024 15:07
@aeddaqqa aeddaqqa changed the title Add new field proposal tx New DAC-Related Transaction Types and API Requests Jun 6, 2024
@aeddaqqa aeddaqqa merged commit 8869603 into dev Jun 7, 2024
6 checks passed
@aeddaqqa aeddaqqa deleted the add-new-field-proposal-tx branch June 7, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants