[TX] Fix owner auth signatures indices for DepositTx + examples #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
When building a deposit tx for a restricted offer from an msig wallet, a certain logic with pseudo addresses is incorporated
(see https://github.com/chain4travel/caminojs/blob/dev/src/apis/platformvm/builder.ts#L1387) to facilitate the processing of signatures in case of a multisig keychain.
However, when building the signature indices in the case of the deposit offer owner, the key cannot be found unless you add it to the keychain with the same pseudo address. See https://github.com/chain4travel/caminojs/blob/dev/src/common/multisigkeychain.ts#L250
How this works
This PR addresses this issue by refactoring
addOwnerAuth
and adding the pseudo addresses in the indices. Thus, when adding the owner signatures to the ms keychain using thegetOwnerSignatures
, there will be a match between the pseudo addresses set in the Output Owners via the builder and the ones added viaaddOwnerAuth
.How this was tested
See new examples.