Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TX] Include AddDesositOfferTx Type in deserialization logic of Unsig… #81

Merged

Conversation

knikos
Copy link
Member

@knikos knikos commented Jul 28, 2023

Why this should be merged

To allow for the deserialization of an AddDepositOfferTx needed in various cases from camino-wallet.

How this works

Adds an if condition in SelectedTxClass for AddDepositOfferTx

How this was tested

@knikos knikos requested review from peak3d and c4t-ag July 28, 2023 08:35
@knikos knikos force-pushed the include-adddepositoffertx-in-unsignedtx-deserialization-logic branch from 56ce543 to a48844d Compare July 28, 2023 08:36
@github-actions
Copy link

⚠️ Found errors/fatal log records. Please review them(job:e2e, step:"Check produced logs") and resolve this comment.

2 errors
0 fatal

@knikos knikos merged commit bccb967 into dev Jul 29, 2023
@knikos knikos deleted the include-adddepositoffertx-in-unsignedtx-deserialization-logic branch July 29, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants