[PVM] New AddDepositOfferTx + associated changes in DepositTx and AddressStateTx #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikos
changed the title
knikos
force-pushed
the
feature/add-deposit-offer-tx
branch
from
fc9d661 to
a455e4b
Compare
|
knikos
force-pushed
the
feature/add-deposit-offer-tx
branch
from
a455e4b to
6d6ecab
Compare
peak3d
force-pushed
the
feature/add-deposit-offer-tx
branch
2 times, most recently
from
68e84d8 to
d1e1066
Compare
knikos
force-pushed
the
feature/add-deposit-offer-tx
branch
from
d1e1066 to
a852d7d
Compare
c4t-ag
requested changes
Jun 28, 2023
knikos
force-pushed
the
feature/add-deposit-offer-tx
branch
from
a852d7d to
b51d9cb
Compare
peak3d
force-pushed
the
feature/add-deposit-offer-tx
branch
from
b51d9cb to
ceb4567
Compare
c4t-ag
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
To support the building and issuing of the new tx AddDepositOfferTx, as well as the new versions of the existing txs DepositTx, AddressStateTx. The PR also adds new e2e tests for related to the new/changed txs mentioned above.
Furthermore, to support the concept of UpgradeVersionID,
How this works
It introduces new txs and updates existing ones as well as their apis and builders. It also integrates the concept of UpgradeVersionIDs and adds a new API
getUpgradePhaseswhich returns Upgrade Version for each phase.The se-/deserialization logic of txs leveraging this new concept is accordingly adjusted.
How this was tested
Unit + e2e tests as well as manually via introduced examples