Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PVM] MultisigAliasTx implementation #75

Merged
merged 1 commit into from
May 30, 2023
Merged

[PVM] MultisigAliasTx implementation #75

merged 1 commit into from
May 30, 2023

Conversation

charalarg
Copy link

Description

This PR adds the MultisigAliasTx implementation on the js library in order to be able to be used from the camino-suite. The equivalent implementation of the MultisigAliasTx on the node is described in this PR

Changes

  • Implementation of the MultisigAliasTx Class that handles the tx logic.
  • Implementation of the MultisigAlias Class which represents the alias definition in the tx.
  • Added api and builder functions.
  • Added unit tests.
  • Added examples for both creating a new multisig alias definition (single sig tx) and updating an already existing ones (multisig tx).

@github-actions
Copy link

github-actions bot commented May 25, 2023 •
edited
Loading

⚠️ Found errors/fatal log records. Please review them(job:e2e, step:"Check produced logs") and resolve this comment.

2 errors
0 fatal

@charalarg charalarg requested review from knikos and peak3d May 25, 2023 11:32
knikos
knikos requested changes May 29, 2023
View reviewed changes
tests/apis/platformvm/multisigaliastx.test.ts Outdated Show resolved Hide resolved
tests/apis/platformvm/multisigaliastx.test.ts Outdated Show resolved Hide resolved
tests/apis/platformvm/multisigaliastx.test.ts Show resolved Hide resolved
src/apis/platformvm/multisigaliastx.ts Outdated Show resolved Hide resolved
examples/common/examplesConfig.json Outdated Show resolved Hide resolved
src/apis/platformvm/api.ts Outdated Show resolved Hide resolved
@knikos knikos self-requested a review May 30, 2023 07:54
c4t-ag
c4t-ag requested changes May 30, 2023
View reviewed changes
examples/common/examplesConfig.json Outdated Show resolved Hide resolved
examples/common/examplesKopernikusConfig.json Outdated Show resolved Hide resolved
@charalarg charalarg requested a review from c4t-ag May 30, 2023 08:58
@charalarg charalarg merged commit ac57b5a into dev May 30, 2023
@charalarg charalarg deleted the msigAliasTx branch May 30, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c4t-ag c4t-ag c4t-ag approved these changes

@knikos knikos knikos approved these changes

@peak3d peak3d Awaiting requested review from peak3d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charalarg @knikos @c4t-ag