[PVM] Added missing condition for claimtx in SelectTxClass #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
knikos
force-pushed
the
bugfix/missing-claimtx-in-selecttxclass
branch
from
e479402 to
8c5f898
Compare
charalarg
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
While introducing the new claimtx logic, no consideration was made for the deserialization of unsignedtx of type ClaimTx.
How this works
Adds an if condition for the claimtx in SelectTxClass logic
How this was tested
Manually
Note: Also changed fromAddresses type from string[] to FromType in buildClaimTx.