[PVM] Introduced e2e test for claiming validator rewards #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parousisv
reviewed
Apr 12, 2023
knikos
force-pushed
the
feature/e2e-validator-rewards
branch
2 times, most recently
from
968f5b6 to
2bea571
Compare
|
knikos
force-pushed
the
feature/e2e-validator-rewards
branch
3 times, most recently
from
21da935 to
3c47dc9
Compare
Checked logs. This error is expected and according to @evlekht should not be removed as it indicates problems if and only if it persists. In our case, it gets printed only cause of the first runs of a network with no previous transactions |
knikos
force-pushed
the
feature/e2e-validator-rewards
branch
from
3c47dc9 to
85813a2
Compare
c4t-ag
requested changes
Apr 25, 2023
jest.config.js
Outdated
| testSequencer: "<rootDir>/e2eSequencer.js", | ||
| testTimeout: 300000 // 5 minutes | ||
| } |
There was a problem hiding this comment.
Pls. add a newline, after this we can go....
knikos
force-pushed
the
feature/e2e-validator-rewards
branch
from
85813a2 to
48aa29a
Compare
c4t-ag
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
To add test coverage to the scenario of a validator claiming rewards. These rewards get exported to from C->P after an adequate number of txs on cchain have accumulated enough gas fees.
The PR addresses the following 2 issues:
How this works
A dummy SC is deployed repeatedly on C Chain to accumulate gas fees. Then enough time (>feeRewardExportMinTimeInterval) is waited and a claim tx for a minimum amount is triggered for one of the validators. Finally, it's verified the claim tx gets committed and that the unlocked amounts of the validator are increased accordingly
How this was tested
Via newly introduced e2e test.