[PVM] Added unit tests for addressStateTx, claimTx, depositTx #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikos
force-pushed
the
feature/various-tx-unit-tests
branch
from
05577f8 to
1d57b83
Compare
… deposittx, registernodetx
knikos
force-pushed
the
feature/various-tx-unit-tests
branch
from
1d57b83 to
b264b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
New camino logic has been added without adequate test coverage. To improve/ensure quality, further testing is essential.
Important: The PR also contains some fixes to discrepancies found in the
fromBuffer/toBufferlogic in the following files:How this works
It introduces new unit tests for camino logic with little to no test coverage.
Note: The field
sourceis excluded from comparison in 'serialize' test cases, as it's not included infromBuffer/toBufferlogic.How this was tested
See newly introduced unit tests.