[PVM] Removed redundant parameter from API getClaimables #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikos
force-pushed
the
bugfix/remove-redundant-parameter-from-getClaimables
branch
from
5fa00e0 to
27449cd
Compare
c4t-ag
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The API getClaimables should be callable without providing any depositTxIds. The only required parameters are those of an interface
Ownerwhere locktime and threshold are optional as the are assigned defualt values if none are provided.How this works
Updates the API by removing the redundant field depositTxIds. Since that renders the
GetClaimablesParamsidentical to theOwnerinterface, the former has been completely removed.How this was tested
By running the corresponding example and ensuring that the API returns a valid response