Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multisig] Implement new camino-node multisig logic #51

Merged
merged 2 commits into from
Mar 20, 2023
Merged

[Multisig] Implement new camino-node multisig logic #51

merged 2 commits into from
Mar 20, 2023

Conversation

c4t-ag
Copy link

@c4t-ag c4t-ag commented Mar 17, 2023 •
edited
Loading

Multisig Rework

  • Spend (the function which creates consumable inputs from UTXO) now supports from and signers (previous only From)
    Multisig TX inputs now have to be queried (with spend) using msig addresses in From and all potential real signers in signers
  • Spend now also returns all OutputOwners from all inputs used in a Tx, we use this information to re-evaluate if enough signers are available to fulfill the verification
  • There is a new CaminoCredential, which allows passing SignatureIndices outside of the unsigned TX, this allows us to create real "sigIdxs" based on the msig adresses which come first.
  • Note that length of SignatureIndices can differ between CaminoCredential and Input, this is because we allow nested multisig and many ways lead to rome.

@c4t-ag c4t-ag requested a review from DerTiedemann March 17, 2023 18:28
@c4t-ag c4t-ag marked this pull request as draft March 17, 2023 18:29
@github-advanced-security
Copy link

You have successfully added a new nodejsscan configuration .github/workflows/njsscan-analysis.yml:njsscan. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@peak3d peak3d force-pushed the peak3d/msig branch 5 times, most recently from 31fc874 to 25c6dd2 Compare March 18, 2023 15:08
@c4t-ag c4t-ag changed the title [Multisig][WIP] Main parts [Multisig] Implement new camino-node multisig logic Mar 18, 2023
@c4t-ag c4t-ag marked this pull request as ready for review March 18, 2023 15:11
@peak3d peak3d force-pushed the peak3d/msig branch 8 times, most recently from 551c69a to ec5b6e8 Compare March 19, 2023 21:12
DerTiedemann
DerTiedemann approved these changes Mar 20, 2023
View reviewed changes
Copy link

@DerTiedemann DerTiedemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, here are some additional examples: #49

[MSIG] RegisterNode and AddValidator Example with MSigAlias (#49)
25ab8fc 
* Updated examples with working signavault simulation

* lint(formating)

* Improvement: Use OutputOwners.from/toArray to serialize/deserialize
@c4t-ag c4t-ag merged commit 76b164f into dev Mar 20, 2023
@c4t-ag c4t-ag deleted the peak3d/msig branch March 20, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerTiedemann DerTiedemann DerTiedemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c4t-ag @DerTiedemann @peak3d