[MultiSig] Implement 2 steps (resolveMultisigIndices -> sign) #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multisig / SigIndices
This PR changes the logic from automatically traversing through msig aliases on sign() in favour of a 2 step logic
Workflow of creating a MultiSig TX
-- flattens the multisig alias /which could be nested from theory) into a single array of addresses
-- if no addresses are provided, wildcard sigIndices are generated
-- replaces the sigIndices for all inputs / auths to the new flattened list
Caveats
In case no addresses are provided in resolveMultisigAlias step (signavault mode), the sigIndices all countain a magic number and no sourceAddress (because it was not known beforehand who signs)
To finally create the correct signatures, the original base outputowners off all input UTXOs have to be either saved or pulled from node using UTXOId to be able to re-run the resolve step and build the signatures in right order.
This is not yet implemented