Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TX] Add remaining platform tx to caminoExecutor (spend / lock) #21

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

c4t-ag
Copy link

@c4t-ag c4t-ag commented Jan 6, 2023

Camino TX / spend adjustment

PR implements all platformTx from utxoset which use getMinimumSpendable.
Instead the JS based UTXO logic we let camino-node / go evaluate the resulting UTXOs.

@c4t-ag c4t-ag requested a review from Chriserus January 6, 2023 19:17
@peak3d peak3d force-pushed the peak3d/addval branch 3 times, most recently from c030300 to 3791b13 Compare January 7, 2023 23:00
Copy link

@Chriserus Chriserus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c4t-ag
Copy link
Author

c4t-ag commented Jan 8, 2023

I was not happy because of all the code changes in UTXO and API, so I reworked platform API:
-> move createTx functions from UTXO into new Builder (which can now either get old or new getMinimumSpendable from interface.
-> Create a Builder class which capsulates the spend call into camino-node.

Pls. @Chriserus review again. I'll merge earliest when evgeni has approves the chnages made in caminogo to you can verify that tx work as expected (e.g. RegisterNodeTx, AddValidatorTx, ImportTx and ExportTx).

@peak3d peak3d force-pushed the peak3d/addval branch 3 times, most recently from 155bd41 to f4e7801 Compare January 8, 2023 14:36
src/apis/platformvm/api.ts Outdated Show resolved Hide resolved
src/apis/evm/api.ts Show resolved Hide resolved
tests/apis/platformvm/api.test.ts Show resolved Hide resolved
@peak3d peak3d force-pushed the peak3d/addval branch 5 times, most recently from 96a8757 to 956fba2 Compare January 9, 2023 21:03
@c4t-ag c4t-ag merged commit f0a5bee into dev Jan 10, 2023
@c4t-ag c4t-ag deleted the peak3d/addval branch January 10, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants