Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peak3d/regnode #19

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Peak3d/regnode #19

merged 2 commits into from
Jan 6, 2023

Conversation

c4t-ag
Copy link

@c4t-ag c4t-ag commented Jan 5, 2023

PR implements the RegisterNodeTx to map an address to a NodeID

  • Cleanup of existing example files
  • Implementation of RegisterNodeTx including additional NodeSig and ConsortiumSig
  • Example which build and executes the tx on kopernikus local network
    Note: inputs / outputs are fetched from node using the new platformVm::spend API function

@c4t-ag c4t-ag requested a review from aeddaqqa January 5, 2023 20:38
aeddaqqa
aeddaqqa reviewed Jan 6, 2023
View reviewed changes
Copy link

@aeddaqqa aeddaqqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Chriserus
Chriserus approved these changes Jan 6, 2023
View reviewed changes
Copy link

@Chriserus Chriserus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just curious - what is a Goose Egg Error? Can't seem to find it online :D

@c4t-ag
Copy link
Author

c4t-ag commented Jan 6, 2023

LGTM Just curious - what is a Goose Egg Error? Can't seem to find it online :D

  • A "Goose Egg Transaction" is when the fee far exceeds a reasonable amount

@c4t-ag c4t-ag merged commit 203a697 into dev Jan 6, 2023
@c4t-ag c4t-ag deleted the peak3d/regnode branch January 6, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeddaqqa aeddaqqa aeddaqqa approved these changes

@Chriserus Chriserus Chriserus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c4t-ag @Chriserus @aeddaqqa @peak3d