[PVM] Node deferring and address state bugfixes #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evlekht
changed the title
evlekht
force-pushed
the
evlekht/addr-state-fix
branch
from
9d60b09 to
496b267
Compare
evlekht
force-pushed
the
evlekht/addr-state-fix
branch
from
496b267 to
d1b9a3d
Compare
Noctunus
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
CaminoRewardValidatorTx node-deferred address state bug
Before Berlin phase, node had bug, that it always preferred onAbortState in proposal CaminoRewardValidatorTx and another bug, where it never updated onAbort node-deferred address state for expired deferred validator.
That lead to CaminoRewardValidatorTx never updating node-deferred address state.
And because Berlin fixes those bugs, we need to persist consistency. This PR fixates this logic with phase, so all pre-Berlin nodes will keep old behavior, but starting with Berlin they will correctly remove node-deferred address-sate bit.
No-op address state transactions
This PR also makes addressStateTx fail if its not modifying target address state. This affects only Berlin nodes.
Other
Also does a few small cleanups.
How this was tested
With existing unit tests and new test cases.