Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVM] Add missing client methods, add encoding arg to block requests #391

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

evlekht
Copy link
Member

@evlekht evlekht commented Nov 1, 2024

Why this should be merged

Adds missing requests to client.
Extends service GetBlockAtHeight and GetLastAcceptedBlock methods with encoding arg allowing to get blocks not only as json, but also as encoded bytes suitable for decoding and parsing with codec.

How this was tested

Manually with cli.

@evlekht evlekht marked this pull request as ready for review November 1, 2024 16:48
@evlekht evlekht merged commit c19e8c0 into dev Nov 4, 2024
10 checks passed
@evlekht evlekht deleted the evlekht/more-blocks-encoding branch November 4, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants