[PVM] limit AddDepositOfferTx zero-limits offer check to berlin phase #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-c4t
approved these changes
Aug 13, 2024
evlekht
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddDepositOfferTxwith bothtx.DepositOffer.TotalMaxAmountandtx.DepositOffer.TotalMaxRewardAmountequal to 0 is already prohibited in current dev (Berlin 0). But columbus network has such tx before Berlin 0, so we need to put this check into berlin phase logic to allow pre-berlin txs with zero limits.