Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCKER, WORKFLOWS] Fix dockerfile, fix already existing symbolic link error, exclude CNR from lint #367

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

evlekht
Copy link
Member

@evlekht evlekht commented Aug 1, 2024

Why this should be merged

caminogo has no dependencies folder anymore

How this works

by removing the line which copies dependencies folder in dockerfile

How this was tested

built docker image locally

Additional references

Original PR based on cortina-4 dev
#298

@evlekht evlekht changed the title Dev c0/fix docker [DOCKER, WORKFLOWS] Fix dockerfile, fix already existing symbolic link error, exclude CNR from lint Aug 2, 2024
@evlekht evlekht force-pushed the dev-c0/fix-docker branch 2 times, most recently from 1d70f1b to 676cbe9 Compare August 2, 2024 16:06
mo-c4t
mo-c4t previously approved these changes Aug 5, 2024
Noctunus
Noctunus previously approved these changes Aug 5, 2024
@evlekht evlekht force-pushed the dev-c0/fix-docker branch from 676cbe9 to b55eba3 Compare August 7, 2024 12:51
@evlekht evlekht changed the base branch from dev-c0/base to dev August 7, 2024 12:52
@evlekht evlekht dismissed stale reviews from Noctunus and mo-c4t August 7, 2024 12:52

The base branch was changed.

@evlekht evlekht marked this pull request as ready for review August 7, 2024 12:52
@evlekht evlekht merged commit eb09c88 into dev Aug 7, 2024
@evlekht evlekht deleted the dev-c0/fix-docker branch August 7, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants