[PVM] Add the functionality of multisig alias definition removal in MultisigAliasTx #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evlekht
force-pushed
the
cortina-15-dev/msig-alias-removal
branch
3 times, most recently
from
492956d to
afcb741
Compare
evlekht
changed the base branch from
evlekht/new-dev-resulting
to
cortina-15-dev/kyb-addr-state
havan
previously approved these changes
Jul 24, 2024
evlekht
force-pushed
the
cortina-15-dev/kyb-addr-state
branch
from
ac55cf6 to
c71e284
Compare
evlekht
force-pushed
the
cortina-15-dev/msig-alias-removal
branch
from
afcb741 to
da14cd4
Compare
mo-c4t
approved these changes
Jul 25, 2024
evlekht
added a commit
that referenced
this pull request
Aug 2, 2024
(cherry picked from commit 3ced756) (cherry picked from commit e59396ee7d1e9694aeb1bfce67910cf39129cc0f)
evlekht
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR adds the functionality of removing a multisig alias definition. Alias cannot be removed if its consortium member or role admin.
How this works
If MultisigAliasTx contains empty multisig alias definition, but non-empty alias ID, than its removal.
To clarify: empty alias definition means that owners has no address and threshold is 0.
How this was tested
By existing unit test with newly added test cases.
Co-authors:
See original PR.
Additional references
Original PR based on cortina-19 dev
#252