[PVM] Add validator admin role, reduce root admin permissions #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evlekht
changed the base branch from
evlekht/new-dev-resulting
to
cortina-15-dev/disable-cairo-proposals
evlekht
force-pushed
the
cortina-15-dev/disable-cairo-proposals
branch
from
14756ca to
40b3706
Compare
evlekht
force-pushed
the
cortina-15-dev/admin-roles
branch
from
98fd67d to
b66d95a
Compare
havan
reviewed
Jul 24, 2024
@havan |
🤦🏼♂️ forgot the filename Line in this PR: https://github.com/chain4travel/caminogo/pull/351/files#diff-4f0263c8deec5a183a8db5cd22b9a69f1458a714d22ec5d51abc047ecbbc5df3L1480
|
evlekht
force-pushed
the
cortina-15-dev/admin-roles
branch
from
b66d95a to
b99c131
Compare
havan
previously approved these changes
Jul 25, 2024
evlekht
force-pushed
the
cortina-15-dev/disable-cairo-proposals
branch
from
40b3706 to
34eae0c
Compare
evlekht
force-pushed
the
cortina-15-dev/admin-roles
branch
from
b99c131 to
2fd3816
Compare
mo-c4t
approved these changes
Jul 25, 2024
evlekht
added a commit
that referenced
this pull request
Aug 1, 2024
(cherry picked from commit 0d9f845)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR improves addr state roles permissions segregation:
There also some renamings to address states.
How this works
In addition to changes in address state permissions logic, there are some changes in tests:
How this was tested
With existing unit-tests and integration tests.
Additional references
Original PR based on cortina-19 dev
#337