[DAC] ExcludeMemberProposal

[evlekht]

Why this should be merged

• Adds exclude member proposal.
• Extends proposals and finishProposalsTx logic to allow successful proposals unbond additional utxos.
• Extracts proposalState types from txs codec to their own dac codec
• Some general renaming and cleanup over dac

How this works

Exclude member proposal

PR adds new proposal type and corresponding proposals executor and verifier implementations.

If successful, exclude member proposal will do:

• unset consortium member address state bit.
• remove registered node short-link, if any
• suspend active validator
• remove pending validator and return its bond

BondTxIDsGetter

Because exclude member proposal is capable of unbonding bond other than proposals, finishProposalsTx was extended to use another proposals visitor: BondTxIDsGetter. This visitor is called for successful proposals and will return any additional bond tx ids that should be unlocked along with proposal bonds.

And because finishProposalsTx is system tx that is built by node, txs/builder pkg has to import dac BondTxIDsGetter implementation. In order to avoid cycle dependencies, dac visitors implementations was extracted from txs/executor to their own txs/dac pkg.

Codec

The reason for creating dac codec for proposalState type is that this types actually not used in transaction bodies, so there is no need for this types to pollute txs codec.

Commits

PR consists of 3 commits:

• ExcludeMemberProposal and all corresponding implementations including BondTxIDsGetter
• General DAC cleanup
• Codec changes

How this was tested

unit-tests, integration tests

Co-authors:

@knikos great help with bondTxIDsGetter improvement

[knikos]

awesome test coverage and test case explanations. thank you!!