Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAC] AddMemberProposal #277

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[DAC] AddMemberProposal #277

merged 1 commit into from
Nov 1, 2023

Conversation

evlekht
Copy link
Member

@evlekht evlekht commented Oct 5, 2023

Why this should be merged

This PR adds new proposal type: addMemberProposal. This proposal contains options "yes" and "no". If proposal is successful and most voted option is "yes", then target address state receives consortium member bit.

How this works

Adds new proposal type and corresponding logic utilizing previously added dac-proposals feature.

How this was tested

Unit-tests

@evlekht evlekht force-pushed the evlekht/dac-add-c-member branch 2 times, most recently from 2a33b4b to b928edd Compare October 5, 2023 15:13
@evlekht evlekht force-pushed the evlekht/dac-add-c-member branch from b928edd to 3936c61 Compare October 26, 2023 13:01
@evlekht evlekht marked this pull request as ready for review October 26, 2023 13:14
@knikos knikos self-requested a review November 1, 2023 12:40
Copy link
Member

@knikos knikos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evlekht evlekht merged commit 16ae286 into dev Nov 1, 2023
5 checks passed
@evlekht evlekht deleted the evlekht/dac-add-c-member branch November 1, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants