Release major version #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7580b7d. The commit didn't trigger an increment of pathval's major version as intended due to the lack of a colon after "BREAKING CHANGE" in the commit message
BREAKING CHANGE: This is a ground up rewrite to make it more useful for chai. Please read the new docs and refactor code to use the new api
|
LGTM 👍 |
|
LGTM! Thanks for the work @meeber 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two commits. The first commit reverts the previous "feat: ground up rewrite" commit, just to maintain history. The second commit is exactly the same as the previous "feat: ground up rewrite" commit but with a colon added after "BREAKING CHANGE".