Remove assertNever assertion for Axios requests #2977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked into this a little and the problem is that the type guard for So I think the real fix is to not use the bugged |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be an error type that axios does not have a type for: Network errors. Because of this, the error value is not really never and therefore we cannot assertNever there.
This does not fix the initial issue though, as the error will still throw.
Should it throw? I'm not really sure what even causes the network error (i did get it myself once when working on a different PR), but it seems to have to do with the backend restarting from code changes, which regular users will not have to deal with.