Add length info for sequences #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I'm going to assume that since you PR'd to it, it's good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reuses the existing "length type" string that was previously implemented but not used. This then adds the rest of the functionality for these types to be usable. Right now, they are only used for adding type tags for sequence length.
They are not used for checking connectability. I plan on doing that in a separate PR.
I also plan on figuring out a way to do things like get folder file amounts and video frame length ahead of time, also in a separate PR.
Also, I can't seem to figure out if its possible to get the input type on merge_spritesheet to be exact. It seems to always want to give it int >= 1 for some reason.
Also, I'm not sure if this is necessarily the best way to represent length (using a number inside brackets) since I just borrowed it from programming, but i wasn't sure what else to do