Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added linked inputs group #1983

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jul 24, 2023

As mentioned on Discord, I made a group to link the values of inputs. While not perfect, it's functional. The main issue is that values are linked via inputData, so sliders aren't synced in real time, but only when a value is entered (slider is released).

image


A for the design: it's not done yet. I'll do it tomorrow.

@joeyballentine
Copy link
Member

How hard would it be to add a way to define the relationship between the inputs? For example if one needs to be double the other, of if two linked file paths should have a different extension?

@RunDevelopment
Copy link
Member Author

How hard would it be to add a way to define the relationship between the inputs?

Not very. The only hurdle is that you need to be able to describe this relationship in a JSON-API-compatible way. But we don't need this right now, so why add it?

@joeyballentine
Copy link
Member

But we don't need this right now, so why add it?

Specifically I'd like to use that for the NCNN load model node, but I guess it's not too big of a deal right now

@RunDevelopment
Copy link
Member Author

Specifically I'd like to use that for the NCNN load model node

Huh? NCNN Load Model already syncs up .bin and .param.

@RunDevelopment
Copy link
Member Author

Design:
image

@RunDevelopment RunDevelopment marked this pull request as ready for review July 25, 2023 19:00
@joeyballentine
Copy link
Member

Huh? NCNN Load Model already syncs up .bin and .param

Yeah but I've always wanted to replace that with a generic implementation. Right now it's just hardcoded on the frontend

@joeyballentine joeyballentine merged commit 081bf70 into chaiNNer-org:main Jul 25, 2023
14 checks passed
@RunDevelopment RunDevelopment deleted the linked-inputs-group branch July 25, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants