Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack many images #1972

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Stack many images #1972

merged 1 commit into from
Jul 23, 2023

Conversation

RunDevelopment
Copy link
Member

This PR extends Stack Images to allow for up to 14 images, just like Z-stack Images.

I also used direct return statements in the node, which allows pyright to prove that we checked all orientation variants, which makes the else: assert False unnecessary.

joeyballentine
joeyballentine approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are some gross types

@joeyballentine joeyballentine merged commit c8f34de into chaiNNer-org:main Jul 23, 2023
10 checks passed
@RunDevelopment RunDevelopment deleted the stack-many-images branch July 23, 2023 20:16
@RunDevelopment
Copy link
Member Author

RunDevelopment commented Jul 23, 2023 •
edited
Loading

Those are some gross types

No array types 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @joeyballentine