Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search highlighting in node docs + other improvements #1956

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Search highlighting in node docs + other improvements #1956

merged 1 commit into from
Jul 20, 2023

Conversation

RunDevelopment
Copy link
Member

image

Other changes:

  • Added missing key prop.
  • The docs modal now manages and performs the search.
  • The best search result is not automatically selected.
  • The modal now remembers the last selected node and search query after closing it.

joeyballentine
joeyballentine approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeyballentine joeyballentine mentioned this pull request Jul 20, 2023
Closed
@joeyballentine joeyballentine merged commit 5fc0d48 into chaiNNer-org:main Jul 20, 2023
4 checks passed
@RunDevelopment RunDevelopment deleted the search-highlight branch July 20, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @joeyballentine