Consider output error for connectability #1725
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1673.
If PR makes it so that inputs are not connectable of the assigned type would cause an output error. So if the target node is valid (no output errors), but the new connections would create output errors, then we don't allow that connection. Examples:
While this enforces the general idea "if it's connectable, it's valid," it also makes it a little harder to edit chains.
E.g. in the Guided Upscale example, I initially had source and guide the other way around by accident. Chainner would not let me assign the other input with the intended value until I removed the old (invalid) connection.
Frankly, I don't know whether I like this. A new user might not realize that they have to remove old invalid connections before they can connect their intended value. This might "trap" new users and lead to frustration. But maybe I'm overthinking here.
Please test this feature and see whether this feature is desirable.