Skip to content

Commit

Permalink
Remove unnecessary transitive dependencies from Jetty
Browse files Browse the repository at this point in the history
Jetty 10.0.18 accidentally added dependencies on `awaitility` and `hamcrest` in `jetty-deploy` via jetty/jetty.project#10667

This workaround can be removed once jetty/jetty.project#10812 is addressed.
  • Loading branch information
chadlwilson committed Oct 31, 2023
1 parent 0519a19 commit 584f7a7
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
4 changes: 3 additions & 1 deletion development-utility/development-server/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ dependencies {
implementation project.deps.jettyJmx
implementation project.deps.jettyServlets
implementation project.deps.jettyUtil
implementation project.deps.jettyDeploy
implementation(project.deps.jettyDeploy) {
exclude(module: 'awaitility') // See https://github.com/jetty/jetty.project/issues/10812
}
implementation(project.deps.jettyWebsocket) {
exclude(module: 'jetty-annotations')
}
Expand Down
8 changes: 6 additions & 2 deletions jetty/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,16 @@ dependencies {
compileOnly project.deps.jettyJmx
compileOnly project.deps.jettyServlets
compileOnly project.deps.jettyUtil
compileOnly project.deps.jettyDeploy
compileOnly(project.deps.jettyDeploy) {
exclude(module: 'awaitility') // See https://github.com/jetty/jetty.project/issues/10812
}
compileOnly(project.deps.jettyWebsocket) {
exclude(module: 'jetty-annotations')
}

testImplementation project.deps.jettyDeploy
testImplementation(project.deps.jettyDeploy) {
exclude(module: 'awaitility') // See https://github.com/jetty/jetty.project/issues/10812
}
testImplementation project.deps.jettyJmx
testImplementation(project.deps.jettyWebsocket) {
exclude(module: 'jetty-annotations')
Expand Down
4 changes: 3 additions & 1 deletion server-launcher/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ dependencies {
packagingInLibDir project.deps.jettyJmx
packagingInLibDir project.deps.jettyServlets
packagingInLibDir project.deps.jettyUtil
packagingInLibDir project.deps.jettyDeploy
packagingInLibDir(project.deps.jettyDeploy) {
exclude(module: 'awaitility') // See https://github.com/jetty/jetty.project/issues/10812
}
packagingInLibDir(project.deps.jettyWebsocket) {
exclude(module: 'jetty-annotations')
}
Expand Down

0 comments on commit 584f7a7

Please sign in to comment.