Update rspec and require newer Ruby versions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes support for ruby 1.9 and removes the patches for the parser and Flog.
saturnflyer
commented
Oct 11, 2024
| @@ -22,5 +22,5 @@ Gem::Specification.new do |s| | |||
| s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") | |||
| s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } | |||
| s.require_paths = ["lib"] | |||
| s.required_ruby_version = '>= 1.8.7' | |||
| s.required_ruby_version = ">= 3.2.0" | |||
There was a problem hiding this comment.
I've made a big jump here but only because this is a recent version of ruby. I did not verify what specific version was necessary but I think it would make sense to switch to Prism for the parser.
I'm happy to walk back any of these changes where there might be concern that they were too aggressive in jumping versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for ruby 1.9 and removes the patches for the parser and Flog.