Skip to content

Commit

Permalink
Add feature archive_param_file to cc toolchain
Browse files Browse the repository at this point in the history
This is a new feature added to the bazel toolchain.
Without it there will not be a link param file on
Windows. For the Skia Parser we encountered this
bug with bazel 6.0.0:
- bazelbuild/bazel#17068

Bug: 267540183
Test: N/A
Change-Id: I31a53dddfa1d570565ffdb95216ca71196f01379

Former-commit-id: 82d995e32ad6fcbc6e019b0a16e8c7fdc862cfcc
  • Loading branch information
jolauridsen committed Feb 17, 2023
1 parent 7310215 commit 98c55e5
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions bazel/toolchains/cc_toolchain_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,11 @@ def _impl(ctx):
],
)

archive_param_file_feature = feature(
name = "archive_param_file",
enabled = True,
)

compiler_param_file_feature = feature(
name = "compiler_param_file",
)
Expand Down Expand Up @@ -1852,6 +1857,7 @@ def _impl(ctx):

if ctx.attr.cpu == "k8":
features = [
archive_param_file_feature,
dependency_file_feature,
random_seed_feature,
pic_feature,
Expand Down Expand Up @@ -1910,6 +1916,7 @@ def _impl(ctx):
]
elif ctx.attr.cpu == "x64_windows":
features = [
archive_param_file_feature,
no_legacy_features_feature,
nologo_feature,
has_configured_linker_path_feature,
Expand Down

0 comments on commit 98c55e5

Please sign in to comment.