Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add prometheus /metrics #716

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

nledez
Copy link
Contributor

@nledez nledez commented Oct 2, 2023

Problem
We need metrics

Solution
Add prometheus metrics endpoint

@nledez nledez force-pushed the prometheus-metrics branch from 09942e5 to f1632a5 Compare October 2, 2023 17:35
@EvanBldy
Copy link
Member

EvanBldy commented Oct 4, 2023

  • disallow the /metrics for unauthenticated users
  • add an environment variable to enable/disable prometheus metrics

@nledez nledez force-pushed the prometheus-metrics branch 2 times, most recently from 0bd4fa8 to d4dd940 Compare October 4, 2023 14:46
@EvanBldy EvanBldy merged commit 1a6039c into cgwire:master Oct 10, 2023
4 checks passed
@nledez nledez deleted the prometheus-metrics branch October 12, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants