Enable --incompatible_disallow_old_style_args_add by default

Fixes bazelbuild#5822 RELNOTES: --incompatible_disallow_old_style_args_add is enabled by default. PiperOrigin-RevId: 235053596
cgruber · Feb 21, 2019 · d4e13ea · d4e13ea
1 parent aaa37f6
commit d4e13ea
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/site/docs/skylark/backward-compatibility.md b/site/docs/skylark/backward-compatibility.md
@@ -232,7 +232,7 @@ parameters are disabled. To add many arguments at once you must use `add_all()`
 or `add_joined()` instead.
 
 *   Flag: `--incompatible_disallow_old_style_args_add`
-*   Default: `false`
+*   Default: `true`
 *   Tracking issue: [#5822](https://github.com/bazelbuild/bazel/issues/5822)
 
 

diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java
@@ -333,7 +333,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl
   /** Controls legacy arguments to ctx.actions.Args#add. */
   @Option(
       name = "incompatible_disallow_old_style_args_add",
-      defaultValue = "false",
+      defaultValue = "true",
       category = "incompatible changes",
       documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
       effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java
@@ -221,7 +221,7 @@ public static Builder builderWithDefaults() {
           .incompatibleDisallowLegacyJavaProvider(false)
           .incompatibleDisallowLegacyJavaInfo(false)
           .incompatibleDisallowLoadLabelsToCrossPackageBoundaries(false)
-          .incompatibleDisallowOldStyleArgsAdd(false)
+          .incompatibleDisallowOldStyleArgsAdd(true)
           .incompatibleDisallowStructProviderSyntax(false)
           .incompatibleExpandDirectories(true)
           .incompatibleNewActionsApi(false)