Skip to content

Commit

Permalink
Enable --incompatible_disallow_old_style_args_add by default
Browse files Browse the repository at this point in the history
Fixes bazelbuild#5822

RELNOTES: --incompatible_disallow_old_style_args_add is enabled by default.
PiperOrigin-RevId: 235053596
  • Loading branch information
laurentlb authored and copybara-github committed Feb 21, 2019
1 parent aaa37f6 commit d4e13ea
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion site/docs/skylark/backward-compatibility.md
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ parameters are disabled. To add many arguments at once you must use `add_all()`
or `add_joined()` instead.

* Flag: `--incompatible_disallow_old_style_args_add`
* Default: `false`
* Default: `true`
* Tracking issue: [#5822](https://github.com/bazelbuild/bazel/issues/5822)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl
/** Controls legacy arguments to ctx.actions.Args#add. */
@Option(
name = "incompatible_disallow_old_style_args_add",
defaultValue = "false",
defaultValue = "true",
category = "incompatible changes",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public static Builder builderWithDefaults() {
.incompatibleDisallowLegacyJavaProvider(false)
.incompatibleDisallowLegacyJavaInfo(false)
.incompatibleDisallowLoadLabelsToCrossPackageBoundaries(false)
.incompatibleDisallowOldStyleArgsAdd(false)
.incompatibleDisallowOldStyleArgsAdd(true)
.incompatibleDisallowStructProviderSyntax(false)
.incompatibleExpandDirectories(true)
.incompatibleNewActionsApi(false)
Expand Down

0 comments on commit d4e13ea

Please sign in to comment.