This repository has been archived by the owner on May 26, 2021. It is now read-only.
Fixed initialization failure when providing an array of elements. #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing an array of elements to the initializer function, e.g.
captionator.captionify([document.getElementById("mainVideo")])
, it would callprocessVideoElement
with an invalidvideoElement
because it used a "spent" iterator index variable for accessing thevideoElements
array.Since the rest of the code in the loop appears to work on an iterator value
videoElement
, it seems this is what should be used anyway.This may also fix the following open issue: #39