Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mechanism to detect inherited static fields #9

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Conversation

cgarciae
Copy link
Owner

@cgarciae cgarciae commented Mar 18, 2023

Fixes #8

  • Change mechanism to detect inherited static fields + some slight optimizations.
  • Adds example from Inheritance of dataclasses #8 as a test.
  • Use frozenset instead of set for safety on various metadata fields.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #9 (5c2314a) into main (8419d6f) will increase coverage by 1.45%.
The diff coverage is 98.71%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   96.00%   97.45%   +1.45%     
==========================================
  Files           2        2              
  Lines         100      118      +18     
==========================================
+ Hits           96      115      +19     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
simple_pytree/pytree.py 97.39% <98.70%> (+1.47%) ⬆️
simple_pytree/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cgarciae cgarciae merged commit 6247038 into main Mar 18, 2023
@cgarciae cgarciae changed the title Change mechanism to detect inherited static fields Fix mechanism to detect inherited static fields Mar 18, 2023
@cgarciae cgarciae deleted the inheritance-issue branch March 18, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inheritance of dataclasses
1 participant