Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dataclass decorator #11

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Custom dataclass decorator #11

merged 4 commits into from
Apr 10, 2023

Conversation

cgarciae
Copy link
Owner

@cgarciae cgarciae commented Apr 9, 2023

Changes

  • Creates a custom dataclass decorator that uses typing_extension.dataclass_transform to indicate to static analysis tools that static_field is a field specifier.
  • Marks default as a keyword-only field. This is a breaking change, version should be bumped to 0.2.0 on next release.

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #11 (7cca625) into main (a4bc7a8) will increase coverage by 0.21%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   97.45%   97.67%   +0.21%     
==========================================
  Files           2        3       +1     
  Lines         118      129      +11     
==========================================
+ Hits          115      126      +11     
  Misses          3        3              
Impacted Files Coverage Δ
simple_pytree/pytree.py 99.04% <ø> (+1.65%) ⬆️
simple_pytree/dataclass.py 90.00% <90.00%> (ø)
simple_pytree/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cgarciae cgarciae merged commit fb81642 into main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant