Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create github actions configuration #13

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Create github actions configuration #13

merged 2 commits into from
Oct 6, 2020

Conversation

mtausig
Copy link
Contributor

@mtausig mtausig commented Oct 6, 2020 •
edited
Loading

  • All test steps previously done by the travis configuration are run using the github actions CI.
  • Flake is not run, because it causes errors (should be tracked in a separate issue)
  • Tests are run on Ubuntu 18.04 and 20.04 (the only linux distros supported by github; others would require a self hosted runner)
  • The capacity of the runners provided by github are apparently not enough for the long tests (I cancelled the execution after 30 minutes)
  • The script is currently executed on all pull requests for master and for direct pushes to master.

@mtausig
Create github actions configuration
d86ef8a 
Run all test steps previously done by the travis configuration (minus flake, which is failing)
lxp
lxp requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@lxp lxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request!
Can we add flake as a non-fatal test for now?

.github/workflows/main.yml Show resolved Hide resolved
lxp
lxp approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@lxp lxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lxp lxp merged commit 7181e8e into cfv-project:master Oct 6, 2020
@mtausig
Copy link
Contributor Author

mtausig commented Oct 6, 2020

Added the flake run ignoring errors: 8dd8c2c
Unfortunately, the UI is not very helpful. You have to open the log in the test details to see that something did not work.

@mtausig
Copy link
Contributor Author

mtausig commented Oct 6, 2020

Could you please add the hacktoberfest-accepted label to this PR.

@mtausig mtausig deleted the CI branch October 6, 2020 22:17
@lxp lxp added the hacktoberfest-accepted Accept for Hacktoberfest label Oct 6, 2020
lxp added a commit that referenced this pull request Jul 12, 2021
@lxp
Merge pull request #13 from mtausig/CI
ca22f12 
Create github actions configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxp lxp lxp approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accept for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtausig @lxp