Rework exceptions and stacktraces #1963
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename `DioException.error` to `DioException.cause` * add `DioException.causeStackTrace` * get rid of `RequestOptions.sourceStackTrace` property * use `Error.throwWithStackTrace` to throw all errors with the manually captured stack trace at a single point in `DioMixin` * extract some inner functions inside `DioMixin.fetch` to prevent them capturing the state of `requestOptions` and `cancelToken` variables, instead pass them as arguments
kuhnroyal
added
s: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An evaluation of how
DioExceptioncan work with better stack traces that can becatched while still being aware of the cause and the stack trace of the cause.Related to #1914
DioException.errortoDioException.causeDioException.causeStackTraceRequestOptions.sourceStackTracepropertyError.throwWithStackTraceto throw all errors with the manually captured stack trace at a single point inDioMixinDioMixin.fetchto prevent them capturing the state ofrequestOptionsandcancelTokenvariables, instead pass them as argumentsNew Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)