Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Dio.download not cleaning the file on data handling error #1915

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Fix for Dio.download not cleaning the file on data handling error #1915

merged 3 commits into from
Aug 2, 2023

Conversation

hgraceb
Copy link
Contributor

@hgraceb hgraceb commented Aug 1, 2023

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@hgraceb hgraceb requested a review from a team as a code owner August 1, 2023 12:13
AlexV525
AlexV525 reviewed Aug 1, 2023
View reviewed changes
dio/lib/src/dio/dio_for_native.dart Outdated Show resolved Hide resolved
dio/lib/src/dio/dio_for_native.dart Outdated Show resolved Hide resolved
@hgraceb hgraceb changed the title Fix Dio.download not closing RandomAccessFile when file writing fails Fix for Dio.download not cleaning the file on data handling error Aug 2, 2023
AlexV525
AlexV525 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@AlexV525 AlexV525 added this pull request to the merge queue Aug 2, 2023
Merged via the queue into cfug:main with commit 074d428 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hgraceb @AlexV525