Introduce labeless input #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change similar to [one of React version](cft-group/elephas-react@8aaa570#diff-fea15a91200b9166e8a52fbfd4d186fb31c222aec38608ba089f9b38fece32a9R24)
Amil-Gaoul
approved these changes
Feb 20, 2021
apust
requested changes
Feb 20, 2021
There was a problem hiding this comment.
- Commits should follow conventional commits rules. There's a pre-push hook for checking that, but it does not work when committing directly from GitHub UI :(
- I think we should not render label
<span>if there's no label. - We need an example of labelless input in Storybook similar to linked React version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change similar to one of React version