-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HKDF in place of ad-hoc PRG currently used by hash_to_base? #137
Comments
Using HKDF is a great idea, indeed! It's also used in TLS 1.3. HKDF-Expand also takes as input a context/info, and ciphersuite/domain separation info would fit in naturally over there.
Come to think about it, we should probably use HKDF for key generation in BLS signatures, since it also takes into account weak randomness used for key generation.
You're doing great! Don't be so harsh on yourself :) |
…ration for H()" Save this until after cfrg#137 is resolved.
+1!
Heavy +1. |
Closed by #141 |
Dan Boneh points out that there's little reason to roll our own PRG inside hash_to_base. Instead, he suggests using HKDF.
(I have to admit, I'm slightly annoyed at myself for having failed to consider this option. Sorry, folks.)
While this makes hash_to_base slightly more expensive, the difference in cost is negligible compared to the end-to-end cost of hashing to a curve.
The main issues I see with taking this approach are:
@hoeteck, thoughts on how this might play out with BLS? I can imagine there isn't a huge appetite for this change. On the other hand, I wonder if we can really justify using a hash_to_base function that lacks rigorous analysis when the (arguably) "right thing" is kind of well known?
The text was updated successfully, but these errors were encountered: