Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/wagtail 50 #73

Closed
wants to merge 6 commits into from
Closed

Conversation

katdom13
Copy link

@katdom13 katdom13 commented Jun 9, 2023

This updates the package for Wagtail 5.0 support.

Support ticket: https://torchbox.monday.com/boards/1124794299/pulses/1131919769

There's no reason the package wouldn't work on versions since 4.1

@katdom13 katdom13 force-pushed the support/wagtail-50 branch 3 times, most recently from f7309f2 to 1397f75 Compare June 9, 2023 10:54
Copy link
Contributor

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chosak
Copy link
Member

chosak commented Jun 9, 2023

@katdom13 @nickmoreton thanks for this!

Any particular reason you removed support for Wagtail 3.x from the pyproject.toml? It'd be nice to maintain support for 3.x unless there's something about adding 5.x support that requires that.

@nickmoreton
Copy link
Contributor

@katdom13 @nickmoreton thanks for this!

Any particular reason you removed support for Wagtail 3.x from the pyproject.toml? It'd be nice to maintain support for 3.x unless there's something about adding 5.x support that requires that.

Hi @chosak Thanks for the question. At TBX we are letting older versions of packages support versions up to one LTS behind the one we are upgrading to. This work then supports the one LTS behind up to 5.0

If this is something you'd rathe not do I'm sure @katdom13 would be happy to revert some of the changes.

I'm just about too look at upgrading another one of your packages. I'll open an issue on that repo for the same question.

@katdom13
Copy link
Author

Hi @chosak ,
I understand that some users may still require support for the EOL TLS version. However, they can choose to use an older version of the package that still supports it.

With that, do we still want to keep the support for 3.x?
Thanks!

@nickmoreton
Copy link
Contributor

Hi @chosak I revisited this PR just now to leave Wagtail v3 as a tested version and include the Wagtail v5 version. I also added in Django 4.2 to be tested along with Wagtail v5

Can you please review this and let me know if you see anything you would like to be changed. Thank you.

@chosak
Copy link
Member

chosak commented Jul 31, 2023

Thank you @katdom13 @nickmoreton! I've merged this in 95fc18e and will create a new package release shortly.

@chosak chosak closed this Jul 31, 2023
@lparsons396 lparsons396 mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants