Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] [Point of Contact] Add the Phone Extension field #945

Closed
Tracked by #265
shindigira opened this issue Sep 19, 2024 · 0 comments · Fixed by #961
Closed
Tracked by #265

[Task] [Point of Contact] Add the Phone Extension field #945

shindigira opened this issue Sep 19, 2024 · 0 comments · Fixed by #961
Assignees
@shindigira

Comments

@shindigira
Copy link
Contributor

shindigira commented Sep 19, 2024 •
edited
Loading

Screenshot (Before)

Screenshot 2024-09-19 at 11 24 37 AM

Screenshots (Completed)

PoC (Desktop) PoC (Mobile) Sign and Submit
Screenshot 2024-09-30 at 9 07 06 AM Screenshot 2024-09-30 at 9 07 20 AM Screenshot 2024-09-30 at 2 18 43 PM
@shindigira shindigira self-assigned this Sep 19, 2024
@shindigira shindigira changed the title [Task] [Point of Contact] Adds the Extension field [Task] [Point of Contact] Add the Extension field Sep 19, 2024
@shindigira shindigira mentioned this issue Sep 23, 2024
Merged
@shindigira shindigira changed the title [Task] [Point of Contact] Add the Extension field [Task] [Point of Contact] Add the Phone Extension field Sep 24, 2024
@natalia-fitzgerald natalia-fitzgerald mentioned this issue Sep 26, 2024
Closed
16 tasks
billhimmelsbach pushed a commit that referenced this issue Oct 1, 2024
@shindigira @billhimmelsbach
[Point of Contact] Phone extension field (#961)
1b58910 
Be sure the pull the latest from
[_sbl-filing_](cfpb/sbl-filing-api#421) via
`yarn update`

closes #945

- feat(Point of Contact): Added Phone Extension field to Point of
Contact Field
- chore(Point of Contact): Phone Extension breakpoint of 600px
- feat(Sign and Submit): Added Phone Extension field to Verification
field
- chore(Sign and Submit): Matched order of fields to be the same as
Point of Contact
- feat(e2e): Added Phone Extension field to e2e test
- style(DisplayField): added `work-break: break-all;`
- content(Sign and Submit): added 'Extension'

1. Upload a filing and navigate all the way to _Point of Contact_
2. Verify the Phone Extension in both mobile and desktop (901 px and
_above_)
3. Open the Network tab, submit and verify the request and response
jsons contain the phone extension (i.e. `phone_ext`)

1. Navigate all the way to _Sign and Submit_
2. Verify the `DisplayField` contains the submitted phone extension

1. Run `yarn run test:e2e`
2. Run the _sign-and-submit_ test to ensure it passes

| PoC (Desktop) | PoC (Mobile) | Sign and Submit |
| -------- | ------- | ------- |
|<img width="533" alt="Screenshot 2024-09-30 at 9 07 06 AM"
src="https://github.com/user-attachments/assets/2210a4d8-e088-4cad-9d78-392aabc0de41">|<img
width="516" alt="Screenshot 2024-09-30 at 9 07 20 AM"
src="https://github.com/user-attachments/assets/cc203268-85bf-4826-8adc-d4740d1a91ea">|<img
width="632" alt="Screenshot 2024-09-30 at 2 18 43 PM"
src="https://github.com/user-attachments/assets/d18a1416-1cbc-494f-a561-d3cd44df22ba">|
This was referenced Oct 1, 2024
Merged
Closed
shindigira added a commit that referenced this issue Oct 1, 2024
@shindigira
stylefix(Point of Contact): Responsive break changed from 600px to 90…
41bb357 
…0px (#977)

Follow-up to #945 

## Style Problem
<img width="432" alt="Screenshot 2024-10-01 at 11 24 06 AM"
src="https://github.com/user-attachments/assets/b9adeb8d-d971-4a96-bd1d-5c254bb43159">
@shindigira shindigira mentioned this issue Oct 1, 2024
Merged
shindigira added a commit that referenced this issue Oct 1, 2024
@shindigira
stylefix(Point of Contact): Phone Extension style 2 to 1 (2/3 to 1/3) (…
88c6612 
…#978)

Follow up to #945

## Changes
- style(PoC): Phone and Phone Extension style flex ratio: 2 to 1 (2/3 to
1/3)

## How to test this PR

1. Toggle between above 900px and below

## Screenshots
<img width="644" alt="Screenshot 2024-10-01 at 2 45 28 PM"
src="https://github.com/user-attachments/assets/e1e6c870-802f-41cf-90d2-c6fd71a23567">
billhimmelsbach pushed a commit that referenced this issue Oct 1, 2024
@shindigira @billhimmelsbach
stylefix(Point of Contact): Responsive break changed from 600px to 90…
41a639a 
…0px (#977)

Follow-up to #945 

## Style Problem
<img width="432" alt="Screenshot 2024-10-01 at 11 24 06 AM"
src="https://github.com/user-attachments/assets/b9adeb8d-d971-4a96-bd1d-5c254bb43159">
billhimmelsbach pushed a commit that referenced this issue Oct 1, 2024
@shindigira @billhimmelsbach
stylefix(Point of Contact): Phone Extension style 2 to 1 (2/3 to 1/3) (…
1a70521 
…#978)

Follow up to #945

## Changes
- style(PoC): Phone and Phone Extension style flex ratio: 2 to 1 (2/3 to
1/3)

## How to test this PR

1. Toggle between above 900px and below

## Screenshots
<img width="644" alt="Screenshot 2024-10-01 at 2 45 28 PM"
src="https://github.com/user-attachments/assets/e1e6c870-802f-41cf-90d2-c6fd71a23567">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shindigira shindigira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Point of Contact] Phone extension field cfpb/sbl-frontend
1 participant
@shindigira