generated from cfpb/open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
67 create post filing task endpoint for updating state #68
Merged
lchen-2101
merged 30 commits into
main
from
67-create-post-filing-task-endpoint-for-updating-state
Feb 27, 2024
Merged
67 create post filing task endpoint for updating state #68
lchen-2101
merged 30 commits into
main
from
67-create-post-filing-task-endpoint-for-updating-state
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-filingperiod-and-filing-objects
…tes-to-filingperiod-and-filing-objects
…create-post-filing-task-endpoint-for-updating-state
jcadam14
requested review from
hkeeler,
guffee23,
lchen-2101 and
nargis-sultani
February 22, 2024 19:10
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
lchen-2101
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lchen-2101
deleted the
67-create-post-filing-task-endpoint-for-updating-state
branch
February 27, 2024 22:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
@router.post("/institutions/{lei}/filings/{period_name}/tasks/{task_name}")
endpointpopulate_missing_tasks
I found during this storyMerged main into here so the commits look like a lot, but not really that many.