Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

67 create post filing task endpoint for updating state #68

Merged

Conversation

jcadam14
Copy link
Contributor

@jcadam14 jcadam14 commented Feb 22, 2024

Closes #67

  • Added @router.post("/institutions/{lei}/filings/{period_name}/tasks/{task_name}") endpoint
  • Added submission_repo functions to help with the storing of FilingTaskState updates
  • Fixed bug in populate_missing_tasks I found during this story
  • Added pytests for new repo and router functions

Merged main into here so the commits look like a lot, but not really that many.

…create-post-filing-task-endpoint-for-updating-state
@jcadam14 jcadam14 self-assigned this Feb 22, 2024
@jcadam14 jcadam14 linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/entities/models
  __init__.py
  dto.py
  src/entities/repos
  submission_repo.py
  src/routers
  filing.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit f20c539 into main Feb 27, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the 67-create-post-filing-task-endpoint-for-updating-state branch February 27, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create POST filing task endpoint for updating state
2 participants