Added filing_task and filing_task_state tables #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New DAOs and DTOs to support filing_task and filing_task_state tables - New FilingTaskState enum - New alembic scripts to create tables and update Filing table to remove "state" field and replace with filingtaskstate relationship - New pytests to test migration and FilingTask and FilingTaskState objects - Updated references to FilingDAO to remove "state" concept and add list of FilingTaskStates
jcadam14
requested review from
hkeeler,
guffee23,
lchen-2101 and
nargis-sultani
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
lchen-2101
reviewed
Feb 7, 2024
|
|
||
|
|
||
| def downgrade() -> None: | ||
| op.drop_table("filing_task_state") |
There was a problem hiding this comment.
does the downgrade remove the custom type just by dropping the table, or do we need to do the drop type thing as well?
There was a problem hiding this comment.
Thank you, updated the downgrade to have a drop of the filingtaskstate TYPE. Note that sqlite doesn't have that concept so it checks for the dialect.
lchen-2101
reviewed
Feb 7, 2024
| class FilingDAO(Base): | ||
| __tablename__ = "filing" | ||
| id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) | ||
| lei: Mapped[str] | ||
| state: Mapped[FilingState] = mapped_column(SAEnum(FilingState)) | ||
| tasks: Mapped[List[FilingTaskStateDAO]] = relationship(lazy="selectin", cascade="all, delete-orphan") | ||
| filing_period: Mapped[int] = mapped_column(ForeignKey("filing_period.id")) | ||
| institution_snapshot_id: Mapped[str] | ||
| contact_info: Mapped[str] = mapped_column(nullable=True) |
There was a problem hiding this comment.
good for this PR, but let's create a ticket to get contact_info as a separate table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45