-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
378 update submission processing to use polars data validator #394
378 update submission processing to use polars data validator #394
Conversation
…rs-data-validator
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
…rs-data-validator
This was tested on the devpub cluster as well as pytests and docker-compose. I had to merge this with the counters PR (#473) since the database and all that had been updated already with that work. So on devpub, it's a combo of these two. But once one of them is approved I'll do the work to merge them in whatever other PR is left open |
except RuntimeError as re: | ||
log.exception("The file is malformed.", re) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be needed, log.exception contains exc_info=True
, which extracts the exception from the stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oop, conflict |
…rs-data-validator
…rs-data-validator
should we update the poetry lock file with the polars update, and the fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #378
Changes the filing-api in the following ways: