Report non-processing state check #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
lchen-2101
reviewed
Jun 21, 2024
src/sbl_filing_api/routers/filing.py
Outdated
| @@ -342,7 +342,7 @@ async def get_latest_submission_report(request: Request, lei: str, period_code: | |||
| "Cache-Control": "no-store", | |||
| }, | |||
| ) | |||
| return JSONResponse(status_code=status.HTTP_204_NO_CONTENT, content=None) | |||
| return JSONResponse(status_code=status.HTTP_404_NOT_FOUND, content=None) | |||
There was a problem hiding this comment.
let's standardize the non-200 code handling and use RegTechHttpException
There was a problem hiding this comment.
same with the other report endpoint
jcadam14
reviewed
Jun 21, 2024
src/sbl_filing_api/routers/filing.py
Outdated
| @@ -352,7 +352,7 @@ async def get_latest_submission_report(request: Request, lei: str, period_code: | |||
| @requires("authenticated") | |||
| async def get_submission_report(request: Request, response: Response, lei: str, period_code: str, id: int): | |||
| sub = await repo.get_submission(request.state.db_session, id) | |||
| if sub: | |||
| if sub and not sub.state == SubmissionState.VALIDATION_IN_PROGRESS: | |||
There was a problem hiding this comment.
This won't work. Submissions could go to VALIDATION_ERROR without writing a report, or SUBMISSION_FAILED, SUBMISSION_UPLOAD, etc. So check for completed states
jcadam14
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286