Added upload file funcitonality #22
Conversation
nargis-sultani
requested review from
lchen-2101,
hkeeler,
guffee23 and
jcadam14
|
The purpose of this ticket was to research and get familiarized with uploading to S3. This PR includes the function to upload to s3, but it is not directly linked to S3. I am using "moto" library to mock s3 for testing. |
nargis-sultani
changed the title
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
lchen-2101
changed the title
| f.write(content) | ||
| except Exception as e: | ||
| log.error("Failed to upload file", e, exc_info=True, stack_info=True) | ||
| raise HTTPException(status_code=HTTPStatus.INTERNAL_SERVER_ERROR, detail="Failed to upload file") |
There was a problem hiding this comment.
If the SubmissionDAO is getting created prior to this possible exception, what would happen to that object? Should we remove it from the database, or set a state on it? Originally the SUBMISSION_UPLOADED was going to be set after saving to S3, but since the object will be created before it now, would it just stay in that state and from that we can infer something bad happened (because it didn't move to VALIDATION_IN_PROGRESS)? This is for #52 really, but wanted to get thoughts so that story is implemented correctly.
There was a problem hiding this comment.
we'll be setting a state on it; so it's an additional one of upload failed, which I don't think we have yet.
closes #4